Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added typeRoots #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eugbyte
Copy link
Contributor

@eugbyte eugbyte commented Jun 29, 2021

No description provided.

@@ -9,7 +9,7 @@
"moduleResolution": "node",
"strict": true,
"baseUrl": ".",
"typeRoots": ["./src/@types", "./node_modules/@types"],
"typeRoots": ["./src/@types", "./src/shared/@types", "./node_modules/@types"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove src/@types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this solution still does not work.

In open-attestation-cli's package.json,

"@govtechsg/open-attestation": "github:eugbyte/open-attestation#experiment/types",

Will have to resolve it by creating our own documentLoader. as you suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants